问题 Laravel - 可重用资源控制器


我正在修改我在项目中使用的CMS，最近我决定为默认操作创建一个控制器 BaseController，所有其他控制器将扩展此控制器 BaseController。

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\Controller;

class BaseController extends Controller
{
    protected $viewFolder = 'admin';

    protected $title;

    protected $model;

    protected $key = 'id';

    protected $files = [];

    public function __construct()
    {
        $this->setVariable('title', $this->title);
    }

    public function index()
    {
        $items = $this->model::paginate();

        $this->setVariable('items', $items);

        return $this->viewRender('index');
    }

    public function create()
    {
        return $this->viewRender('create');
    }

    public function store(ExampleStoreRequestFROMEXAMPLECONTROLLER $request)
    {
        $item = $this->model::create($request->all());

        return redirect()->route($this->viewFolder.'.'.$this->viewType.'.show', $item[$this->key]);
    }

    public function show($id)
    {
        $item = $this->model::where($this->key, $id)->firstOrFail();

        $this->setVariable('item', $item);

        return $this->viewRender('show');
    }

    public function edit($id)
    {
        $item = $this->model::where($this->key, $id)->firstOrFail();

        $this->setVariable('item', $item);

        return $this->viewRender('edit');
    }

    public function update(ExampleUpdateRequestFROMEXAMPLECONTROLLER $request, $id)
    {
        $item = $this->model::where($this->key, $id)->firstOrFail();

        $item->update($request->except(['_token', '_method']));

        return redirect()->route($this->viewFolder.'.'.$this->viewType.'.show', $item[$this->key]);
    }

    public function status(ExampleStatusRequestFROMEXAMPLECONTROLLER $request, $id)
    {
        $this->model::where($this->key, $id)->update($request->except('_method'));

        return response()->json([
            'message' => 'O status foi alterado com sucesso'
        ]);
    }

    public function destroy($id)
    {
        $this->model::where($this->key, $id)->delete();

        return redirect()->route($this->viewFolder.'.'.$this->viewType.'.index');
    }
}

问题是：我写了 BaseController 使用表格请求 UserController 我不知道如何保留这些请求动态，以便我可以从其他控制器实现它们。

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Requests\ExampleStatusRequest;
use App\Http\Requests\ExampleStoreRequest;
use App\Http\Requests\ExampleUpdateRequest;

class ExampleController extends BaseController
{
    protected $viewType = 'users';

    protected $model = 'App\Example';

    public function index()
    {
        $this->setVariable('title', 'Usuários');
        return parent::index();
    }

    public function create()
    {
        $this->setVariable('title', 'Cadastrar usuário');
        return parent::create();
    }

    public function store(ExampleStoreRequest $request)
    {
        return parent::store($request);
    }

    public function edit($id)
    {
        $this->setVariable('title', 'Editar usuário');
        return parent::edit($id);
    }

    public function update(ExampleUpdateRequest $request, $id)
    {
        return parent::update($request, $id);
    }

    public function status(ExampleStatusRequest $request, $id)
    {
        return parent::status($request, $id);
    }
}

这是我的默认控制器：

<?php

namespace App\Http\Controllers;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;

class Controller extends BaseController
{
    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;

    protected $viewFolder = '';

    protected $viewType = '';

    protected $viewVariables = [];

    protected function setVariable($key, $value)
    {
        $this->viewVariables[$key] = $value;
    }

    protected function viewRender($view)
    {
        return view($this->viewFolder.'.pages.'.$this->viewType.'.'.$view, $this->viewVariables);
    }
}

知道怎么解决这个问题吗？


12011
2018-05-04 19:48


起源
可以使用PHP的 func_get_args。 - DigitalDrifter
如果我理解你正在尝试做什么，那么简单的答案是：在PHP中没有干净的方法来做到这一点。 PHP真的很糟糕。 （略微更多）高级面向对象或通用编程几乎没有自由。这一切都归结为你提出这个问题的原因是你在编程方面正在推进多态思维。 PHP缺乏你的思维水平，这意味着它是时候继续前进了！开始使用更多面向对象的语言（也许可以看看C＃（和ASP.net））。 - Joas
我喜欢 viewRender （或者我可以建议使用renderView）实现。但是，保持简单会发生什么？这个实现不会漏掉很多低级细节吗？真的值得吗？ - joshuamabina
你为什么要寻找快捷方式？初学者倾向于这样做（在那里，做到了）。在这种情况下，小重复比抽象更好。随着越来越多的用例被引入，您的抽象类肯定会增加并增加复杂性。你会以一个很大的泥球结束，这将是一个难以维护的地方，因为你想首先编写更少的代码。让控制器尽可能简单，独立，并且总是优先于继承。我现在习惯DDD，我从不使用 extends 了。 - emix

答案:

评论之后，我可以更好地理解。 我在这里遇到了同样的问题，这是我的解决方法

class BaseController extends Controller
{

     protected function _store($request)
     {
     ....
     }
 ...
 }

 class MyController extends BaseController
 {
 ....
      public function store(MyRequest $request)
      {
          //do something
          return parent::_store($request);
      }
 }

7
2018-05-04 19:52


以及如何将UserStoreRequest发送到BaseController @ store？你能展示代码吗？ - Caio Kawasaki
你不能同时使用它们 ExampleStatusRequest 和 UserStoreRequest 与此同时。你可以做的是创建另一个名为的控制器 UserController那太遗传了 BaseController。 - Felippe Duarte
这是计划！我怎么能通过 UserStoreRequest 到了 BaseController 来自 ExampleController？ - Caio Kawasaki
用UserStoreRequest替换ExampleStatusRequest，并从BaseController中删除UserStoreRequest - Felippe Duarte
错误：App \ Http \ Controllers \ Admin \ ExampleController :: store（App \ Http \ Requests \ ExampleStoreRequest $ request）的声明应该与App \ Http \ Controllers \ Admin \ BaseController :: store（$ request）兼容 - Caio Kawasaki

任何 CustomFormRequest 您将使用的，将是一个实例 FormRequest..一个反过来扩展的类 Request 类。所以在你的 BaseController 做这个：

BaseController.php

use Illuminate\Http\Request;

// some code

    public function store(Request $request)
    {
        $item = $this->model::create($request->all());

        return redirect()
            ->route($this->viewFolder.'.'.$this->viewType.'.show', item[$this->key]);
        }

// The rest of your code..

然后在你的孩子控制器：

AChildController.php

class AChildController extends BaseController
{

use App\Http\Requests\ACustomFormRequest;

// Some code

  public function store(ACustomFormRequest $request)
  {
      //do something
      return parent::_store($request);
  }

}

试一试。


2
2018-05-09 08:59 



class BaseController extends Controller
{

     protected function _store($request)
     {
     ....
     }
 ...
 }

 class MyController extends BaseController
 {
 ....
      public function store(MyRequest $request)
      {
          //do something
          return parent::_store($request);
      }
 }

1
2018-05-10 06:49



简短回答：

绑定。

一 Route::model。

一个 简单的绑定 对于每个表单请求类型，使用接口 控制器中的方法注入。

长答案适用于您的示例：

模型绑定 routes/web.php：

<?php

Route::model('example', App\Example::class);
Route::resource('example', 'Admin\ExampleController');

请求Controller Base中的绑定：

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Requests;
use App\Http\Controllers\Controller;

class BaseController extends Controller
{
    // Your code...

    /**
     * @var string[]|callable[]
     */
    protected $bindings = [];

    /**
     * Controller constructor.
     */
    public function __construct()
    {
        $this->addBindings();
    }

    /**
     * Add controller specific bindings.
     */
    protected function addBindings()
    {
        $app = Container::getInstance();

        foreach ($this->getBindings() as $abstract => $concrete) {
            $app->bind($abstract, $concrete);
        }
    }

    // Your code...

    public function store(Requests\StoreRequestInterface $request)
    {
        // Your code...
    }

    public function show(Model $item)
    {
        // Your code...
    }

    public function edit(Model $item)
    {
        // Your code...
    }

    public function update(Requests\UpdateRequestInterface $request, Model $model)
    {
        // Your code...
    }

    public function status(Requests\StatusRequestInterface $request, Model $model)
    {
        // Your code...
    }

    public function destroy(Model $item)
    {
        // Your code...
    }

    // Your code...
}

和示例控制器：

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Requests;

class ExampleController extends BaseController
{
    // Your code...

    /**
     * @var string[]|callable[]
     */
    protected $bindings = [
        Requests\StatusRequestInterface::class => Requests\ExampleStatusRequest::class,
        Requests\StoreRequestInterface::class  => Requests\ExampleStoreRequest::class,
        Requests\UpdateRequestInterface::class => Requests\ExampleUpdateRequest::class,
    ];

    // Your code...
}

所以Requests接口看起来像这样：

<?php

namespace App\Http\Requests;

interface StoreRequestInterface
{
}

您应该将它用作表单请求中的接口：

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;

class ExampleStoreRequest extends FormRequest implements StoreRequestInterface
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            //
        ];
    }
}

意见的替代答案：

一般控制器基础：

<?php

namespace App\Http\Controllers;

use Illuminate\Container\Container;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;

abstract class Controller extends BaseController
{
    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;

    /**
     * The view subdirectory that must be used.
     *
     * @var string
     */
    protected $viewDir;

    /**
     * Bindings
     *
     * @var string[]|callable[]
     */
    protected $bindings = [];

    /**
     * Controller constructor.
     */
    public function __construct()
    {
        $this->addViewPath();
        $this->addBindings();
        $this->init();
    }

    /**
     * @return void
     */
    protected function init()
    {
        //
    }

    /**
     * @return string
     */
    protected function getViewDir()
    {
        return $this->viewDir;
    }

    /**
     * @return callable[]|string[]
     */
    protected function getBindings()
    {
        return $this->bindings;
    }

    /**
     * Add controller specific view path.
     */
    protected function addViewPath()
    {
        if (null !== ($dir = $this->getViewDir()) && ($path = realpath(base_path('resources/views/' . $dir)))) {
            view()->getFinder()->addLocation($path);
        }
    }

    /**
     * Add controller specific bindings.
     */
    protected function addBindings()
    {
        $app = Container::getInstance();

        foreach ($this->getBindings() as $abstract => $concrete) {
            $app->bind($abstract, $concrete);
        }
    }
}

资源控制器基础：

<?php

namespace App\Http\Controllers;

use Illuminate\Database\Eloquent\Model;
use App\Http\Requests\StoreRequestInterface;
use App\Http\Requests\UpdateRequestInterface;
use App\Http\Requests\StatusRequestInterface;

abstract class ResourceController extends Controller
{
    /**
     * Model class
     *
     * @var string
     */
    protected $modelClass;

    /**
     * @var string
     */
    protected $viewDirPrefix;

    /**
     * @return string
     */
    protected function getViewDir()
    {
        return $this->viewDir ?:
            ltrim($this->viewDirPrefix . DIRECTORY_SEPARATOR . 'pages', DIRECTORY_SEPARATOR) .
            DIRECTORY_SEPARATOR . strtolower(class_basename($this->modelClass));
    }

    /**
     * @return \Illuminate\Database\Eloquent\Builder
     */
    protected function getQuery()
    {
        return call_user_func($this->modelClass . '::query');
    }

    /**
     * @return string
     */
    protected function getName()
    {
        return __(class_basename($this->modelClass));
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    protected function index()
    {
        $title = __('resource.title.index', ['name' => str_plural($this->getName())]);
        $models = $this->getQuery()->paginate();

        return view('index', compact('title', 'models'));
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    protected function create()
    {
        $title = __('resource.title.create', ['name' => $this->getName()]);

        return view('create', compact('title'));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request|StoreRequestInterface $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreRequestInterface $request)
    {
        $model = $this->getQuery()->create($request->all());

        return redirect()
            ->route(substr($request->route()->getName(), 0, -5) . 'show', $model);
    }

    /**
     * Display the specified resource.
     *
     * @param  \Illuminate\Database\Eloquent\Model $model
     *
     * @return \Illuminate\Http\Response
     */
    public function show(Model $model)
    {
        $title = __('resource.title.show', ['name' => $this->getName()]);

        return view('show', compact('title', 'model'));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \Illuminate\Database\Eloquent\Model $model
     *
     * @return \Illuminate\Http\Response
     */
    public function edit(Model $model)
    {
        $title = __('resource.title.edit', ['name' => $this->getName()]);

        return view('edit', compact('title', 'model'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request|UpdateRequestInterface $request
     * @param  \Illuminate\Database\Eloquent\Model             $model
     *
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateRequestInterface $request, Model $model)
    {
        $model->update($request->except(['_token', '_method']));

        return redirect()
            ->route(substr($request->route()->getName(), 0, -6) . 'show', $model);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \Illuminate\Database\Eloquent\Model $model
     *
     * @return \Illuminate\Http\Response
     * @throws \Exception
     */
    public function destroy(Model $model)
    {
        $model->delete();

        return redirect()
            ->route(substr(request()->route()->getName(), 0, -7) . 'index');
    }

    /**
     * @param \Illuminate\Http\Request|StatusRequestInterface $request
     * @param \Illuminate\Database\Eloquent\Model             $model
     *
     * @return \Illuminate\Http\Response|\Illuminate\Http\JsonResponse
     */
    protected function status(StatusRequestInterface $request, Model $model)
    {
        $model->update($request->except('_method'));

        return response()->json([
            'message' => __('resource.status.success'),
        ]);
    }
}

资源控制器 Example 模型：

<?php

namespace App\Http\Controllers\Admin;

use App\Example;
use App\Http\Requests;
use App\Http\Controllers\ResourceController;

class ExampleController extends ResourceController
{
    /**
     * Model class
     *
     * @var string
     */
    protected $modelClass = Example::class;

    /**
     * @var string
     */
    protected $viewDirPrefix = 'admin';

    /**
     * @var string[]|callable[]
     */
    protected $bindings = [
        Requests\StatusRequestInterface::class => Requests\Example\StatusRequest::class,
        Requests\StoreRequestInterface::class  => Requests\Example\StoreRequest::class,
        Requests\UpdateRequestInterface::class => Requests\Example\UpdateRequest::class,
    ];
}

英语语言文件 resources/lang/en/resource.php：

<?php

return [
    'title'  => [
        'index'  => 'All :Name',
        'create' => 'Create :Name',
        'show'   => 'Show :Name',
        'edit'   => 'Edit :Name',
    ],
    'status' => [
        'success' => 'Status updated successfully',
    ],
];

葡萄牙语语言文件 resources/lang/pt/resource.php：

<?php

return [
    'title'  => [
        'index'  => 'Todos os :Name',
        'create' => 'Cadastrar :Name',
        'show'   => 'Show :Name',
        'edit'   => 'Editar :Name',
    ],
    'status' => [
        'success' => 'O status foi alterado com sucesso',
    ],
];

网络路线 routes/web.php：

<?php

Route::group([
    'as'        => 'admin.',
    'prefix'    => 'admin',
    'namespace' => 'Admin',
], function () {
    Route::model('example', App\Example::class);
    Route::resource('example', 'ExampleController');
});

请求接口（用于绑定）：

<?php

namespace App\Http\Requests;

interface StoreRequestInterface
{
}

同样的 App\Http\Requests\UpdateRequestInterface 和 App\Http\Requests\StatusRequestInterface...

示例表单请求：

<?php

namespace App\Http\Requests\Example;

use Illuminate\Foundation\Http\FormRequest;
use App\Http\Requests\StoreRequestInterface;

class StoreRequest extends FormRequest implements StoreRequestInterface
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return false;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            //
        ];
    }
}

同样的 App\Http\Requests\Example\UpdateRequest 和 App\Http\Requests\Example\StatusRequest...

适用于此回复的文档：

注意： 本回复适用于Laravel 5.6。预览版本不支持此回复中使用的某些代码。如果您想要特定版本，请告诉我，我会尝试对其进行调整。


1
2018-05-13 18:44



热门问题

不使用eval / new函数的JavaScript模板库 当涉及内部类时，Java继承如何工作 .NET Windows服务的奇怪问题 在.ipa或.app下查找App ID 快速入门XSLT参考[关闭] 如何找出Android应用程序中未使用的资源 Ruby中并发的同步方法[重复] 将std :: chrono :: system_clock :: time_point转换为struct timeval并返回 Google Drive API V3（javascript）更新文件内容 Bootstrap 3.0 - 将元素推到底部 受密码保护的.NET ClickOnce部署？ 如何用postgresql安装wordpress coq Set或Type如何成为命题 硒滚动元素进入（中心）视图 在Spring Transaction JUnit测试中自动装配Hibernate会话的正确方法 Git的Dockerfile策略 如何在FOS_PICKFOLDER中使用IFileDialog，同时仍在对话框中显示文件名 在Firefox扩展中复制Google Chrome浏览器操作弹出效果 CakePHP找到MAX 芹菜 - 完成任务的召唤功能 从使用fmemopen创建的流中读取宽字符 .NET是否为每个程序集创建一个字符串实习池？ DefaultModelBinder不绑定嵌套模型 Navigator.MediaDevices.getUserMedia（）使用了哪些相机通信标准？ 选择命名空间名称时应该知道什么？ cout Swagger Codegen CLI Java客户端 - 如何正确使用它 一个很好的哈希函数用于采访整数，字符串？ Maven 3 ciManagement配置的目的是什么？ 如何通过语言文化获取代码页？
licensed under cc by-sa 3.0 with attribution.
隐私政策 往来