问题 我可以从动作过滤器中获取Action的返回类型吗?


我有一个ASP.NET MVC 2应用程序,我在其中创建自定义操作过滤器。此过滤器位于应用程序中的控制器上,并从数据库验证该功能当前是否可用。

Public Overrides Sub OnActionExecuting(ByVal filterContext As System.Web.Mvc.ActionExecutingContext)
  Try
    ' Check controller name against database.
    Dim controllerName = filterContext.Controller.GetType().Name
    controllerName = controllerName.Remove(controllerName.Length - 10)
    ' Look up availability.
    Dim available As Boolean = _coreService.GetControllerAvailability(controllerName)
    If Not available Then
      ' Redirect to unavailable notice.
      filterContext.Result = New RedirectResult("/Home/Unavailable/")
    End If
  Catch ex As Exception
    _eventLogger.LogWarning(ex, EventLogEntryType.Error)
    Throw
  End Try
End Sub

我的问题是,根据已请求的操作,我需要将用户重定向到返回视图,部分视图或JSON的操作。

鉴于ActionExecutingContext,我可以找出最初请求的操作的返回类型是什么?

编辑:

好吧,我越来越近了,但又有另一个问题。

Public Overrides Sub OnActionExecuting(ByVal filterContext As System.Web.Mvc.ActionExecutingContext)
  Try
    ' Check controller name against database.
    Dim controllerName = filterContext.Controller.GetType().Name
    Dim shortName = controllerName.Remove(controllerName.Length - 10)
    ' Look up availability.
    Dim available As Boolean = _coreService.GetControllerAvailability(shortName)
    If Not available Then
      ' find out what type is expected to be returned
      Dim actionName As String = filterContext.ActionDescriptor.ActionName
      Dim controllerType = Type.GetType("Attenda.Stargate.Web." & controllerName)
      Dim actionMethodInfo = controllerType.GetMethod(actionName)
      Dim actionReturnType = actionMethodInfo.ReturnType.Name

      Select Case actionReturnType
        Case "PartialViewResult"
          filterContext.Result = New RedirectResult("/Home/UnavailablePartial/")
        Case "JsonResult"
          filterContext.Result = New RedirectResult("/Home/UnavailableJson/")
        Case Else
          filterContext.Result = New RedirectResult("/Home/Unavailable/")
      End Select

    End If
  Catch ex As Exception
    _eventLogger.LogWarning(ex, EventLogEntryType.Error)
    Throw
  End Try
End Sub

我可以使用反射来查找动作方法的返回类型。我的问题是如果我在控制器上有以下方法:

Public Function Create() As ViewResult
  Return View()
End Function

<AcceptVerbs(HttpVerbs.Post)>
Public Function Create(values as FormCollection) As ViewResult
  ' Do stuff here
End Function

我抛出了一个AmbiguousMatchException。

使用OnActionExecuting方法中的信息,无论如何更确切地确定正在调用的重载?


9814
2018-05-19 11:35


起源



答案:


我基于此创建了一个AuthenticationFilterAttribute,它根据类型返回不同的结果:

    /// <summary>
    /// Access to the action will be blocked if the user is not logged in. 
    ///  Apply this to the controller level or individual actions as an attribute.
    /// </summary>
    public class AuthenticationFilterAttribute : ActionFilterAttribute
    {
        protected const string InvalidAccess = "Invalid access";

        public override void OnActionExecuting(ActionExecutingContext filterContext)
        {
            // Find out if the user is logged in: 
            Controller controller = (Controller)filterContext.Controller;
            if (!controller.User.Identity.IsAuthenticated)
            {
                switch (GetExpectedReturnType(filterContext).Name)
                {
                    case "JsonResult":
                        var jsonResult = new JsonResult();
                        jsonResult.Data = new { Error = true, ErrorMessage = InvalidAccess };
                        jsonResult.JsonRequestBehavior = JsonRequestBehavior.AllowGet;
                        filterContext.Result = jsonResult;
                        break;

                    // Assume same behaviour as ActionResult
                    default: 
                        var actionResult = new ContentResult();
                        actionResult.Content = InvalidAccess;
                        filterContext.Result = actionResult;
                        break;
                }
            }
        }

        private Type GetExpectedReturnType(ActionExecutingContext filterContext)
        {
            // Find out what type is expected to be returned
            string actionName = filterContext.ActionDescriptor.ActionName;
            Type controllerType = filterContext.Controller.GetType();
            MethodInfo actionMethodInfo = default(MethodInfo);
            try
            {
                actionMethodInfo = controllerType.GetMethod(actionName);
            }
            catch (AmbiguousMatchException ex)
            {
                // Try to find a match using the parameters passed through
                var actionParams = filterContext.ActionParameters;
                List<Type> paramTypes = new List<Type>();
                foreach (var p in actionParams)
                {
                    paramTypes.Add(p.Value.GetType());
                }

                actionMethodInfo = controllerType.GetMethod(actionName, paramTypes.ToArray());
            }

            return actionMethodInfo.ReturnType;
        }
    }

9
2018-02-15 00:59



有趣的解决方案,谢谢。请注意,如果filterContext.ActionDescriptor的类型为System.Web.Mvc.ReflectedActionDescriptor,则它已经具有MethodInfo属性,因此您无需担心确定它。 - Toby J


答案:


我基于此创建了一个AuthenticationFilterAttribute,它根据类型返回不同的结果:

    /// <summary>
    /// Access to the action will be blocked if the user is not logged in. 
    ///  Apply this to the controller level or individual actions as an attribute.
    /// </summary>
    public class AuthenticationFilterAttribute : ActionFilterAttribute
    {
        protected const string InvalidAccess = "Invalid access";

        public override void OnActionExecuting(ActionExecutingContext filterContext)
        {
            // Find out if the user is logged in: 
            Controller controller = (Controller)filterContext.Controller;
            if (!controller.User.Identity.IsAuthenticated)
            {
                switch (GetExpectedReturnType(filterContext).Name)
                {
                    case "JsonResult":
                        var jsonResult = new JsonResult();
                        jsonResult.Data = new { Error = true, ErrorMessage = InvalidAccess };
                        jsonResult.JsonRequestBehavior = JsonRequestBehavior.AllowGet;
                        filterContext.Result = jsonResult;
                        break;

                    // Assume same behaviour as ActionResult
                    default: 
                        var actionResult = new ContentResult();
                        actionResult.Content = InvalidAccess;
                        filterContext.Result = actionResult;
                        break;
                }
            }
        }

        private Type GetExpectedReturnType(ActionExecutingContext filterContext)
        {
            // Find out what type is expected to be returned
            string actionName = filterContext.ActionDescriptor.ActionName;
            Type controllerType = filterContext.Controller.GetType();
            MethodInfo actionMethodInfo = default(MethodInfo);
            try
            {
                actionMethodInfo = controllerType.GetMethod(actionName);
            }
            catch (AmbiguousMatchException ex)
            {
                // Try to find a match using the parameters passed through
                var actionParams = filterContext.ActionParameters;
                List<Type> paramTypes = new List<Type>();
                foreach (var p in actionParams)
                {
                    paramTypes.Add(p.Value.GetType());
                }

                actionMethodInfo = controllerType.GetMethod(actionName, paramTypes.ToArray());
            }

            return actionMethodInfo.ReturnType;
        }
    }

9
2018-02-15 00:59



有趣的解决方案,谢谢。请注意,如果filterContext.ActionDescriptor的类型为System.Web.Mvc.ReflectedActionDescriptor,则它已经具有MethodInfo属性,因此您无需担心确定它。 - Toby J


好的,这是我提出的解决方案。

Public Overrides Sub OnActionExecuting(ByVal filterContext As System.Web.Mvc.ActionExecutingContext)
  Try
    ' Check controller name against database.
    Dim controllerName = filterContext.Controller.GetType().Name
    Dim shortName = controllerName.Remove(controllerName.Length - 10)
    ' Look up availability.
    Dim available As Boolean = _coreService.GetControllerAvailability(shortName)
    If Not available Then
      ' find out what type is expected to be returned
      Dim actionName As String = filterContext.ActionDescriptor.ActionName
      Dim controllerType = Type.GetType("Attenda.Stargate.Web." & controllerName)
      Dim actionMethodInfo As MethodInfo
      Try
        actionMethodInfo = controllerType.GetMethod(actionName)
      Catch ex As AmbiguousMatchException
        ' Try to find a match using the parameters passed through
        Dim actionParams = filterContext.ActionParameters
        Dim paramTypes As New List(Of Type)
        For Each p In actionParams
          paramTypes.Add(p.Value.GetType())
        Next
        actionMethodInfo = controllerType.GetMethod(actionName, paramTypes.ToArray)
      End Try
      Dim actionReturnType = actionMethodInfo.ReturnType.Name

      Select Case actionReturnType
        Case "PartialViewResult"
          filterContext.Result = New RedirectResult("/Home/UnavailablePartial/")
        Case "JsonResult"
          filterContext.Result = New RedirectResult("/Home/UnavailableJson/")
        Case Else
          filterContext.Result = New RedirectResult("/Home/Unavailable/")
      End Select

    End If
  Catch ex As Exception
    _eventLogger.LogWarning(ex, EventLogEntryType.Error)
    Throw
  End Try
End Sub

如果Type.GetMethod(string)调用无法识别请求的方法,我将从ActionExecutingContext.ActionParameters集合中获取参数集合,并构建请求中传递的参数类型的数组。然后我可以使用Type.GetMethod(string,type())重载来更具体地说明我的请求。


2
2018-05-19 15:04





到...的时候 OnActionExecuting 在调用时,action方法还没有被执行,所以你无法知道该action方法是否会返回哪个子类 ActionResult。所以,除非你可以使用CIL分析实现(我觉得很快就会变丑),我不认为你想做什么是可能的。

也就是说,当控制器不够用时,是不是将用户重定向到视图?我的意思是,我不明白为什么要将用户重定向到JSON结果或部分视图。


0
2018-05-19 12:33



该网站是我们客户的门户网站。我有一些页面,如主页与其他控制器的部分视图。我想返回一个部分视图,并在父视图中返回一条消息。家庭控制器将始终可用,但报告控制器可能不可用。报告小部件应该只显示礼貌的消息。 - Nick
@Nick:那么为什么不执行像filterContext.Result = New PartialViewResult(...)之类的操作,而不管action方法返回的实际操作结果如何? - Buu Nguyen
如果他们期待局部视图,那就没问题。如果他们点击/ Reports / Index虽然他们不喜欢裸露的部分视图回来。我已经用我使用反射所取得的进展更新了我的问题。 - Nick
我也想过了反射方法,但只有在严格声明你的action方法返回ActionResult的特定子类时才有效。这可能并不总是可能的,因为你可能有一些条件代码,比如if(cond1)返回Json(...); else返回JavaScript(...);而且,无论返回特定的子类,使用ActionResult几乎都是一种约定。也就是说,如果你能忍受这些已知的约束,那么反射是一种选择。 - Buu Nguyen
@Nick:关于更新的帖子:要正确选择方法,在许多不同的重载中,你需要遵循MVC所做的解决步骤来找到匹配。具体来说,您应该查看内部类ActionMethodSelector的方法FindActionMethod(在MVC 2源代码中)。如果你很幸运,那么你可以重复使用该方法而不需要太多的改变和许多依赖 - 我自己没有尝试过。 - Buu Nguyen